diff options
| author | Arne Schwabe | 2020-07-19 19:34:32 +0200 |
|---|---|---|
| committer | Gert Doering | 2020-07-19 19:44:02 +0200 |
| commit | 82241468cb631e7a06a213198a3a13734c6a091e (patch) | |
| tree | 72d4a3702ec504480611844d31c0c5eb692cc7f4 /Changes.rst | |
| parent | 4cabd28a77116ab3926f81258af9bdb342e0336a (diff) | |
| download | openvpn-82241468cb631e7a06a213198a3a13734c6a091e.zip openvpn-82241468cb631e7a06a213198a3a13734c6a091e.tar.gz | |
Remove CAS_PARTIAL state
This state is used to handle a corner case when multiple connect
handlers are active and one of them fails. Unfortunately, this state
complicates the state machine a bit without a good benefit.
Current behaviour:
First/all connect handler(s) fail:
- client disconnect handler is not called at all
At least one connect handler succeeds but a subsequent handler fails:
- client disconect is called when we actually
disconnect the client (a few seconds later, max tls timeout)
All connect handlers suceed:
- client disconect is called when we actually
disconnect the client
This patches changes the behaviour in the second to immediately
call disconnect_handler in this case.
This simplifies the logic that already caused a bug and the
behaviour change is very little and affects only a pretty
exotic corner case.
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20200719173436.16431-1-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20482.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Diffstat (limited to 'Changes.rst')
| -rw-r--r-- | Changes.rst | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/Changes.rst b/Changes.rst index e522869..34abcd9 100644 --- a/Changes.rst +++ b/Changes.rst @@ -38,6 +38,13 @@ https://community.openvpn.net/openvpn/wiki/DeprecatedOptions This option was made into a NOOP option with OpenVPN 2.4. This has now been completely removed. +User-visible Changes +-------------------- +- If multiple connect handlers are used (client-connect, ccd, connect + plugin) and one of the handler succeeds but a subsequent fails, the + client-disconnect-script is now called immediately. Previously it + was called, when the VPN session was terminated. + Overview of changes in 2.4 ========================== |