diff options
| author | Samuli Seppänen | 2016-05-19 11:51:49 +0300 |
|---|---|---|
| committer | Gert Doering | 2016-05-19 11:22:50 +0200 |
| commit | 698f0dab76741f4ce8c1a98236786d59eca338ef (patch) | |
| tree | ad6aa616850ff4f7bbf7fa156d9823340e304bfa /CONTRIBUTING.rst | |
| parent | 0d8a4ffa2293dda8139189725a5c49fbe0eb500b (diff) | |
| download | openvpn-698f0dab76741f4ce8c1a98236786d59eca338ef.zip openvpn-698f0dab76741f4ce8c1a98236786d59eca338ef.tar.gz | |
Update CONTRIBUTING.rst to allow GitHub PRs for code review purposes
Signed-off-by: Samuli Seppänen <samuli@openvpn.net>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1463647909-18383-1-git-send-email-samuli@openvpn.net>
URL: http://article.gmane.org/gmane.network.openvpn.devel/11679
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Diffstat (limited to 'CONTRIBUTING.rst')
| -rw-r--r-- | CONTRIBUTING.rst | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 6033097..f87293c 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -4,15 +4,19 @@ CONTRIBUTING TO THE OPENVPN PROJECT Patches should be written against the Git "master" branch. Some patches may get backported to a release branch. -We do not currently accept GitHub pull requests for the core OpenVPN project. -Instead, all patches must be sent to "openvpn-devel" mailing list for review: +The preferred procedure to send patches to the "openvpn-devel" mailing list: - https://lists.sourceforge.net/lists/listinfo/openvpn-devel -The subject line should preferably be prefixed with [PATCH]. To avoid merging -issues the patches should be generated with git-format-patch or sent using -git-send-email. Try to split large patches into small, atomic pieces to make -reviews easier. +While we do not merge GitHub pull requests as-is, we do allow their use for code +review purposes. After the patch has been ACKed (reviewed and accepted), it must +be sent to the mailing list. This last step does not necessarily need to be done +by the patch author, although that is definitely recommended. + +When sending patches to "openvpn-devel" the subject line should be prefixed with +[PATCH]. To avoid merging issues the patches should be generated with +git-format-patch or sent using git-send-email. Try to split large patches into +small, atomic pieces to make reviews easier. If you want quick feedback on a patch before sending it to openvpn-devel mailing list, you can visit the #openvpn-devel channel on irc.freenode.net. Note that |