aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLev Stipakov2023-07-10 14:21:22 +0300
committerGert Doering2023-07-11 21:25:06 +0200
commitaceecaef79cd2dae5265e328874ee8263ac79492 (patch)
tree113ffde40797854c9e75a234e9dad8e8efa6a4b5
parent66f51e80b981f08ebc3c38f3fac7d0c88caeb85d (diff)
downloadopenvpn-aceecaef79cd2dae5265e328874ee8263ac79492.zip
openvpn-aceecaef79cd2dae5265e328874ee8263ac79492.tar.gz
tun.c: enclose DNS domain in single quotes in WMIC call
This is needed to support domains with hyphens. Not using double quotes here, since our code replaces them with underbars (see https://github.com/OpenVPN/openvpn/blob/master/src/openvpn/win32.c#L980). Github: fixes OpenVPN/openvpn#363 Change-Id: Iab536922d0731635cef529b5caf542f637b8d491 Signed-off-by: Lev Stipakov <lev@openvpn.net> Acked-by: Selva Nair <selva.nair@gmail.com> Message-Id: <20230710112122.576-1-lstipakov@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26841.html Signed-off-by: Gert Doering <gert@greenie.muc.de> (cherry picked from commit 4057814a8a783d4fb1475f49f073f6b3a7797677)
-rw-r--r--src/openvpn/tun.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index 4ef390a..af959bb 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -335,7 +335,7 @@ do_dns_domain_wmic(bool add, const struct tuntap *tt)
}
struct argv argv = argv_new();
- argv_printf(&argv, "%s%s nicconfig where (InterfaceIndex=%ld) call SetDNSDomain %s",
+ argv_printf(&argv, "%s%s nicconfig where (InterfaceIndex=%ld) call SetDNSDomain '%s'",
get_win_sys_path(), WMIC_PATH_SUFFIX, tt->adapter_index, add ? tt->options.domain : "");
exec_command("WMIC", &argv, 1, M_WARN);